Remote auto_publish field from Publisher #3424
Conversation
| last_export (models.DatetimeField): When the last successful export occurred. | ||
|
|
||
| Relations: | ||
|
|
||
| """ | ||
| TYPE = 'exporter' | ||
|
|
||
| name = models.CharField(max_length=255, db_index=True, unique=True) |
There was a problem hiding this comment.
This should probably be a TextField like all the others.
There was a problem hiding this comment.
...or maybe all the names should be CharField, instead. TextField is really meant for long blobs of text, CharField for short ones that need to be size-bounded.
We just need to be consistent.
There was a problem hiding this comment.
I don't think we know the max length of all strings, so that change would be pretty big. https://docs.pulpproject.org/en/3.0/nightly/contributing/3.0-development/data-modeling.html?highlight=textfield#introduction
| @@ -169,16 +165,15 @@ class Exporter(MasterModel): | |||
|
|
|||
| Fields: | |||
|
|
|||
| name (models.CharField): The exporter unique name. | |||
| last_updated (models.DatetimeField): Timestamp of the last update. | |||
There was a problem hiding this comment.
Defined on the Master model, not here.
| last_export (models.DatetimeField): When the last successful export occurred. | ||
|
|
||
| Relations: | ||
|
|
||
| """ | ||
| TYPE = 'exporter' | ||
|
|
||
| name = models.CharField(max_length=255, db_index=True, unique=True) |
There was a problem hiding this comment.
I don't think we know the max length of all strings, so that change would be pretty big. https://docs.pulpproject.org/en/3.0/nightly/contributing/3.0-development/data-modeling.html?highlight=textfield#introduction
There was a problem hiding this comment.
Oops, found one more. remove auto_publish here too:
https://github.com/pulp/pulp/pull/3424/files#diff-6668e3ab3f516fb6325897ab6e3cf7e4R163
closes: #3545
https://pulp.plan.io/issues/3545