This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
FIPS: Setting the usedforsecurity flag to False if available #3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosemania
reviewed
May 18, 2018
| TYPE_SHA = 'sha' | ||
| TYPE_SHA1 = hashlib.sha1().name | ||
| TYPE_SHA256 = hashlib.sha256().name | ||
|
|
||
| HASHLIB_ALGORITHMS = (TYPE_MD5, TYPE_SHA, TYPE_SHA1, TYPE_SHA256) | ||
|
|
||
| CHECKSUM_FUNCTIONS = { | ||
| TYPE_MD5: hashlib.md5, | ||
| TYPE_MD5: md5, |
There was a problem hiding this comment.
I think either this should be md5() or def md5 should return the result when called and not a function. WDYT?
goosemania
approved these changes
May 18, 2018
There was a problem hiding this comment.
Thanks, @daviddavis ! 🎉 Looks good to me.
Please figure out unit tests failures (if they are relevant or not) before merging/
|
ok test |
1 similar comment
|
ok test |
In some builds of Python, a usedforsecurity flag is available to declare that md5 is not being used for security purposes. Set this flag if it's available. This is required for FIPS environments.
|
ok test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some builds of Python, a usedforsecurity flag is available to declare that md5 is not being used for security purposes. We're using md5 for checksums so set this flag if it's available. This is required for FIPS environments.