This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Adds nightly doc building to travis #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dkliban! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on July 13, 2018 at 15:09 Hours UTC |
dkliban
force-pushed
the
move-docs-building-to-travis
branch
from
9af166b
to
5569e36
Compare
dralley
approved these changes
Jul 10, 2018
daviddavis
reviewed
Jul 10, 2018
.travis.yml
Outdated
| @@ -1,19 +1,27 @@ | |||
| language: python | |||
| python: | |||
| - "2.7" | |||
| - '3.6' | |||
There was a problem hiding this comment.
Minor grip but typically arrays in yaml are indented.
There was a problem hiding this comment.
In the files below (e.g. .travis/2-master.yaml) you're indenting array entries.
daviddavis
suggested changes
Jul 10, 2018
| @@ -0,0 +1,13 @@ | |||
| Documentation Index | |||
There was a problem hiding this comment.
I feel like these files aren't necessarily specific to Travis? Thoughts on maybe moving these to the top level docs directory?
There was a problem hiding this comment.
They are specific to the way we build docs for docs.pulpproject.org. You can build the docs in this repo by themselves and they will not include plugin information.
dkliban
force-pushed
the
move-docs-building-to-travis
branch
from
5569e36
to
15a6eed
Compare
The 2-master branch will be setup to build using cron on Travis. When this build is trigerred, the docs for branches defined in .travis/2-master.yaml will be built and published. re: pulp#3722 https://pulp.plan.io/issues/3722
dkliban
force-pushed
the
move-docs-building-to-travis
branch
from
15a6eed
to
2259509
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2-master branch will be setup to build using cron on Travis. When this build is trigerred, the
docs for branches defined in .travis/2-master.yaml will be built and published.
re: #3722
https://pulp.plan.io/issues/3722