Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Fixing tests after pulp_file change and sphinx options #3627

Merged
merged 1 commit into from Sep 12, 2018
Merged

Fixing tests after pulp_file change and sphinx options #3627

merged 1 commit into from Sep 12, 2018

Conversation

daviddavis
Copy link
Contributor

@daviddavis daviddavis commented Sep 12, 2018

@pep8speaks
Copy link

pep8speaks commented Sep 12, 2018

Hello @daviddavis! Thanks for updating the PR.

Line 30:1: E402 module level import not at top of file
Line 36:1: E265 block comment should start with '# '
Line 50:1: E265 block comment should start with '# '
Line 72:1: E265 block comment should start with '# '
Line 76:1: E265 block comment should start with '# '
Line 78:1: E265 block comment should start with '# '
Line 85:1: E265 block comment should start with '# '
Line 88:1: E265 block comment should start with '# '
Line 92:1: E265 block comment should start with '# '
Line 96:1: E265 block comment should start with '# '
Line 102:1: E265 block comment should start with '# '
Line 120:1: E265 block comment should start with '# '
Line 127:1: E265 block comment should start with '# '
Line 130:1: E265 block comment should start with '# '
Line 134:1: E265 block comment should start with '# '
Line 139:1: E265 block comment should start with '# '
Line 148:1: E265 block comment should start with '# '
Line 152:1: E265 block comment should start with '# '
Line 155:1: E265 block comment should start with '# '
Line 159:1: E265 block comment should start with '# '
Line 162:1: E265 block comment should start with '# '
Line 165:1: E265 block comment should start with '# '
Line 168:1: E265 block comment should start with '# '
Line 171:1: E265 block comment should start with '# '
Line 174:1: E265 block comment should start with '# '
Line 177:1: E265 block comment should start with '# '
Line 182:1: E265 block comment should start with '# '
Line 185:1: E265 block comment should start with '# '
Line 194:1: E122 continuation line missing indentation or outdented
Line 195:1: E122 continuation line missing indentation or outdented
Line 195:1: E265 block comment should start with '# '
Line 197:1: E122 continuation line missing indentation or outdented
Line 198:1: E122 continuation line missing indentation or outdented
Line 198:1: E265 block comment should start with '# '
Line 200:1: E122 continuation line missing indentation or outdented
Line 201:1: E122 continuation line missing indentation or outdented
Line 201:1: E265 block comment should start with '# '
Line 207:3: E121 continuation line under-indented for hanging indent
Line 213:1: E265 block comment should start with '# '
Line 217:1: E265 block comment should start with '# '
Line 220:1: E265 block comment should start with '# '
Line 223:1: E265 block comment should start with '# '
Line 226:1: E265 block comment should start with '# '
Line 229:1: E265 block comment should start with '# '
Line 242:1: E265 block comment should start with '# '
Line 251:3: E121 continuation line under-indented for hanging indent
Line 257:1: E265 block comment should start with '# '
Line 260:1: E265 block comment should start with '# '
Line 263:1: E265 block comment should start with '# '
Line 309:87: E231 missing whitespace after ','

Comment last updated on September 12, 2018 at 19:02 Hours UTC

@nixocio
Copy link

nixocio commented Sep 12, 2018

I am running those modified tests in a fresh source installation.

@daviddavis
Copy link
Contributor Author

@kersommoura great, thanks.

@nixocio
Copy link

nixocio commented Sep 12, 2018

Tested

pytest -v -s pulpcore/tests/functional/
87 passed, 4 skipped in 299.40 seconds 

@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@7f0e814). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3627   +/-   ##
=========================================
  Coverage          ?   56.78%           
=========================================
  Files             ?       60           
  Lines             ?     2617           
  Branches          ?        0           
=========================================
  Hits              ?     1486           
  Misses            ?     1131           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f0e814...17b0a0f. Read the comment docs.

@daviddavis daviddavis changed the title Fixing tests after change to manifest change in #3912 Fixing tests after pulp_file change and sphinx options Sep 12, 2018
@daviddavis daviddavis merged commit 23f9b5f into pulp:master Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants