This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Improve Artifact generation and saving for content app #3818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor Artifact generation for "on_demand" policy into method of its own. This allows derived plugin content handlers to customize the saving part. - Don't fail if the Artifact already exists. This may happen if multiple content instances share the same artifact or if the content type does not have enough metadata to ensure uniqueness without downloading the actual artifact (i.e. no digest in metadata). fixes #4293 https://pulp.plan.io/issues/4293
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #3818 +/- ##
==========================================
+ Coverage 52.9% 55.68% +2.78%
==========================================
Files 65 64 -1
Lines 2805 2796 -9
==========================================
+ Hits 1484 1557 +73
+ Misses 1321 1239 -82
Continue to review full report at Codecov.
|
|
@bmbouter Here is the PR I mentioned today on IRC |
|
Looks good to me, but I will let @bmbouter review also. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Artifact generation for "on_demand" policy into method of its own.
This allows derived plugin content handlers to customize the saving part.
Don't fail if the Artifact already exists. This may happen if multiple
content instances share the same artifact or if the content type does not
have enough metadata to ensure uniqueness without downloading the actual
artifact (i.e. no digest in metadata).
fixes #4293
https://pulp.plan.io/issues/4293