Namespace plugin endpoints with Django app label

[goosemania]

closes #4279
https://pulp.plan.io/issues/4279

[pep8speaks]

Hello @goosemania! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on January 23, 2019 at 21:05 Hours UTC

[goosemania]

@dralley , I'd appreciate your critical look at this PR.

It results in the following (notice name):

^pulp/api/v3/ ^remotes/file/file/$ [name='remotes-file/file-list']
^pulp/api/v3/ ^remotes/file/file\.(?P<format>[a-z0-9]+)/?$ [name='remotes-file/file-list']
^pulp/api/v3/ ^remotes/file/file/(?P<pk>[^/.]+)/$ [name='remotes-file/file-detail']
^pulp/api/v3/ ^remotes/file/file/(?P<pk>[^/.]+)\.(?P<format>[a-z0-9]+)/?$ [name='remotes-file/file-detail']
^pulp/api/v3/ ^remotes/file/file/(?P<pk>[^/.]+)/sync/$ [name='remotes-file/file-sync']
^pulp/api/v3/ ^remotes/file/file/(?P<pk>[^/.]+)/sync\.(?P<format>[a-z0-9]+)/?$ [name='remotes-file/file-sync']
^pulp/api/v3/ ^content/rpm/packages/$ [name='content-rpm/packages-list']
^pulp/api/v3/ ^content/rpm/packages\.(?P<format>[a-z0-9]+)/?$ [name='content-rpm/packages-list']
^pulp/api/v3/ ^content/rpm/packages/(?P<pk>[^/.]+)/$ [name='content-rpm/packages-detail']
^pulp/api/v3/ ^content/rpm/packages/(?P<pk>[^/.]+)\.(?P<format>[a-z0-9]+)/?$ [name='content-rpm/packages-detail'] 

[goosemania]

I'll fix tests and plugins after LGTM on approach here.

[dralley]

@goosemania Approach looks good, LGTM

[codecov]

Codecov Report

Merging #3836 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #3836      +/-   ##
=========================================
+ Coverage   55.57%   55.6%   +0.03%     
=========================================
  Files          66      66              
  Lines        2818    2820       +2     
=========================================
+ Hits         1566    1568       +2     
  Misses       1252    1252

Impacted Files	Coverage Δ
pulpcore/app/viewsets/base.py	78.37% <100%> (+0.29%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d32f8e...7654d5d. Read the comment docs.

[daviddavis]

Had a question. Other than that LGTM.

[daviddavis]

I'm not sure I understand this change. Shouldn't FILE_CONTENT_PATH still be /pulp/api/v3/content/file/files/ and not /pulp/api/v3/content/files/?

[goosemania]

@daviddavis , you're right. Thank you!
I was surprised, why tests didn't fail, so after some investigation, I found a problem with installation of pulp_file, so test were skipped. Fixed as well now

[goosemania]

@daviddavis , ready for re-review

[bmbouter]

This looks good to me. Thanks for putting this together!