This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Skarmark applicability perf improvements #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skarmark
commented
Aug 23, 2013
skarmark
commented
- updated get_repo_units conduit method to request only the required unit association data resulting in 65% performance improvement for applicability and much better memory footprint.
- performance improvements to ApplicabilityRegenerationManager to avoid multiple calls per consumer for retrieving profiles and bound repos.
- updated repo applicability regeneration to check only existing RepoProfileApplicability objects instead of creating new objects when needed.
added 4 commits
August 22, 2013 16:32
…nit association data resulting in 65% peformance improvement for applicability and much better memory footprint
… multiple calls per consumer for retrieving profiles and bound repos.
…rofileApplicability objects instead of creating new objects when needed
ghost
assigned 
| for repo_binding in all_repo_bindings: | ||
| if unit_profile['consumer_id'] == repo_binding['consumer_id']: | ||
| # Check if applicability for given profile_hash and bound_repo_id already exists | ||
| existing_applicability = ApplicabilityRegenerationManager._get_existing_applicability( |
There was a problem hiding this comment.
this will still end up doing lots of database queries regardless of how few profiles there are. Comments will appear above with additional suggestions.
added 3 commits
August 23, 2013 13:38
…te duplicate profiles with same hash corresponding to a given repository. This results in an improved performance, especially when there are a lot of same consumer profiles.
|
Looks good. One last request: can we wrap all of this to about 110 characters? Lots of lines are too long to fit in the github display. |
skarmark
pushed a commit
that referenced
this pull request
Aug 26, 2013
…ments Skarmark applicability perf improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.