Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a broken test #584

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Conversation

bmbouter
Copy link
Member

A test was broken due to increased validation added to the
galaxy-importer dependnecy. Although that validation hasn't been
released, it was causing our tests to fail which use the master branch
of galaxy-importer.

This switches the collection being uploaded in the test to one which
passes the galaxy-importer validation requirements.

closes #8882

@bmbouter bmbouter requested a review from a team as a code owner June 10, 2021 16:50
@pep8speaks
Copy link

pep8speaks commented Jun 10, 2021

Hello @bmbouter! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-10 17:47:32 UTC

@bmbouter bmbouter force-pushed the fixes-broken-nightly-test branch 2 times, most recently from 6991663 to 7a8436e Compare June 10, 2021 16:54
Copy link
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change and it should be good to go.

Comment on lines 37 to 39
import pydevd_pycharm

pydevd_pycharm.settrace("localhost", port=29437, stdoutToServer=True, stderrToServer=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmbouter leftover debugging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol thanks

@pulpbot
Copy link
Member

pulpbot commented Jun 10, 2021

Attached issue: https://pulp.plan.io/issues/8882

A test was broken due to increased validation added to the
`galaxy-importer` dependnecy. Although that validation hasn't been
released, it was causing our tests to fail which use the master branch
of `galaxy-importer`.

This switches the collection being uploaded in the test to one which
passes the `galaxy-importer` validation requirements.

closes #8882
@bmbouter bmbouter merged commit 9d67e70 into pulp:master Jun 10, 2021
@bmbouter bmbouter deleted the fixes-broken-nightly-test branch June 10, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants