Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the path and query string of the URL to generate a 'validate_token'. #146

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Use the path and query string of the URL to generate a 'validate_token'. #146

merged 1 commit into from
Sep 8, 2020

Conversation

dkliban
Copy link
Member

@dkliban dkliban commented Sep 8, 2020

@pulpbot
Copy link
Member

pulpbot commented Sep 8, 2020

Attached issue: https://pulp.plan.io/issues/7462

mdellweg
mdellweg approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should still include the querystring.

@mdellweg mdellweg self-requested a review September 8, 2020 15:12
@dkliban dkliban changed the title Use the path of the URL to generate a 'validate_token'. Use the path and query string of the URL to generate a 'validate_token'. Sep 8, 2020
mdellweg
mdellweg approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@dkliban dkliban merged commit 3da1c4a into pulp:master Sep 8, 2020
@dkliban dkliban deleted the 7462 branch September 8, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdellweg mdellweg mdellweg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkliban @pulpbot @mdellweg