Update cookbook plugin

[fao89]

No description provided.

[gmbnomis]

@fao89 This looks like you are trying to get this plugin running again, which would be great. Let me know if I can help.

[fao89]

@fao89 This looks like you are trying to get this plugin running again, which would be great. Let me know if I can help.

could you please review?

[gmbnomis]

Nice work! However, I would like to understand the problems with test_contentview.py better.

[gmbnomis]

I am not sure why you consider this test to be be a functional test as well. Looking at it, it does

from pulp_cookbook.tests.functional.constants import COOKBOOK_CONTENT_PATH

which it should not do. Are there other aspects that are causing problems in this test?

[fao89]

it seems to do some API calls: https://github.com/pulp/pulp_cookbook/blob/main/pulp_cookbook/tests/unit/test_contentview.py#L67

We run unit tests inside the container and functional tests outside,
https://github.com/pulp/pulp_cookbook/runs/5116620108?check_suite_focus=true
I tried copying pulp-smash config to the container, but it broke:
https://github.com/pulp/pulp_cookbook/runs/5117392394?check_suite_focus=true
because pulp-smash assumes it is running outside of the container,
so I decided to skip this test until I figure out how to run it on CI.

[gmbnomis]

it seems to do some API calls: https://github.com/pulp/pulp_cookbook/blob/main/pulp_cookbook/tests/unit/test_contentview.py#L67

It shouldn't do any real calls as this client is the APIClient from the REST framework, which acts as a "dummy" client simulating requests to views. In a pulplift environment this test works when Pulp is shut down.

We run unit tests inside the container and functional tests outside, https://github.com/pulp/pulp_cookbook/runs/5116620108?check_suite_focus=true I tried copying pulp-smash config to the container, but it broke: https://github.com/pulp/pulp_cookbook/runs/5117392394?check_suite_focus=true because pulp-smash assumes it is running outside of the container, so I decided to skip this test until I figure out how to run it on CI.

I hope that removing the functional test & pulp-smash dependency will suffice. As we only depend on COOKBOOK_CONTENT_PATH, we could set the constant here directly:

COOKBOOK_CONTENT_PATH = "/pulp/api/v3/content/cookbook/cookbooks/"

Worth a try IMHO. If that does not work, let's remove the test and deal with is separately as you propose. wdyt?

[fao89]

it worked!
Thank you @gmbnomis