-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor (some) class-names to Apt #180
Conversation
WARNING!!! This PR is not attached to an issue. In most cases this is not advisable. Please see our PR docs for more information about how to attach this PR to an issue. |
e961965
to
d28a89d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like it, but I also do see one possible obstacle. Can you please try the migration with a seeded db. I am unsure if existing objects are properly accounted for. You might need to add a handcrafted step.
Since the original cause for this change, was inconsistent naming between class names, and API paths, I went and had another look at those. I wanted to draw attention one more time to the verbatim publisher since it is the other thing with an unusual name:
But this now seems structurally consistent. Also consistent when compared to
|
I am not sure if this is a meaningful test, but for what it is worth, I was still able to find everything in my source development box after applying the migration. How else can I test this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell the changelog entry is the only change we need...
fixes #6897
d28a89d
to
1d5c864
Compare
@m-bucher Do we need to confirm one more time that this really does fix the original issue with the auto generated API bindings? |
@quba42 I will check it out in my forklift. |
@quba42 The katello-tests now no longer produce the broken URL, so I guess that is a good sign 😃 |
@mdellweg I will have one more look at a migration tomorrow, and then I would merge this. |
Should fix https://pulp.plan.io/issues/6897
Please comment about possible obstacles.