This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Make requests to docker registry with bearer tokens #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| If the download fails due to a 401, attempt to retreive a token and try again. | ||
| """ | ||
| if report.error_report.get('response_code') == 401: |
There was a problem hiding this comment.
I like referencing values from httplib, which in this case would be httplib.UNAUTHORIZED, just to be extra-explicit about context for what the value is and what it means. But it's probably just a matter of taste. No need to change unless you want to.
| query_dict = urlparse.parse_qs(parse_result.query) | ||
| query_dict.update(auth_info) | ||
| url_pieces = list(parse_result) | ||
| url_pieces[4] = urllib.urlencode(query_dict) |
There was a problem hiding this comment.
It's a pain in the ass, but for the sake of readability I'd rather see this either be spelled out, e.g. url_pieces = [parse_result.scheme, parse_result.hostname, ...], or just throw a comment along the lines of # replace the parsed query string, urlpieces[4]
closes #1144 closes #1596
asmacdo
added a commit
that referenced
this pull request
Feb 3, 2016
Make requests to docker registry with bearer tokens
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1144
https://pulp.plan.io/issues/1596
https://pulp.plan.io/issues/1144
Note: This will hang indefinitely due to https://pulp.plan.io/issues/1567, so Nectar will need to be rebuilt for this to function correctly. @ipanova