Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Add check for duplicate unit key during v1 sync. #156

Merged
merged 1 commit into from
Jun 29, 2016
Merged

Add check for duplicate unit key during v1 sync. #156

merged 1 commit into from
Jun 29, 2016

Conversation

ipanova
Copy link
Member

@ipanova ipanova commented Jun 7, 2016

@ipanova ipanova added the bug label Jun 7, 2016
@jortel jortel self-assigned this Jun 16, 2016
@jortel
Copy link
Contributor

jortel commented Jun 16, 2016

The fix looks good but missing unit test coverage. Looks like the process_main() method is missing unit test coverage all together. Adding a test for the whole method goes beyond the scope of your work but I think it would be the right thing to do since you need your code changes covered anyway.

@jortel jortel assigned ipanova and unassigned jortel Jun 16, 2016
@ipanova ipanova force-pushed the issue1925 branch 3 times, most recently from 892a852 to 4efed18 Compare June 28, 2016 12:37
@jortel jortel self-assigned this Jun 28, 2016
@jortel jortel added the LGTM label Jun 29, 2016
@jortel jortel removed their assignment Jun 29, 2016
@ipanova ipanova merged commit 139659c into pulp:2.0-dev Jun 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ipanova ipanova

Labels
bug LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipanova @jortel