Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload #276

Merged
merged 1 commit into from
Sep 27, 2019
Merged

File upload #276

merged 1 commit into from
Sep 27, 2019

Conversation

mdellweg
Copy link
Member

@pep8speaks
Copy link

pep8speaks commented Sep 16, 2019

Hello @mdellweg! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-20 15:43:11 UTC

@mdellweg mdellweg force-pushed the upload_create_serializer branch 6 times, most recently from 5388af4 to 3e1fed0 Compare September 16, 2019 12:35
@mdellweg mdellweg marked this pull request as ready for review September 16, 2019 12:59
@mdellweg mdellweg requested a review from a team September 16, 2019 12:59
@@ -41,7 +46,9 @@ def tearDownClass(cls):
def test_01_create_content_unit(self):
"""Create content unit."""
attrs = gen_file_content_attrs(self.artifact)
self.content_unit.update(self.client.post(FILE_CONTENT_PATH, attrs))
call_report = self.client.post(FILE_CONTENT_PATH, data=attrs)
created_resources = next(api.poll_spawned_tasks(self.cfg, call_report))["created_resources"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdellweg, thanks for writing those tests.

Pulp-Smash has a handler to deal with 202 and Pulp 3.

https://pulp-smash.readthedocs.io/en/latest/api/pulp_smash.api.html#pulp_smash.api.smart_handler

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

pulp_file/tests/functional/api/test_crud_content_unit.py Outdated Show resolved Hide resolved
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 17, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulp_file#276
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 19, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulp_file#276
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 20, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulp_file#276
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 20, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulpcore#305
Required PR: pulp/pulp_file#276
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 20, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulpcore#305
Required PR: pulp/pulp_file#276
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 20, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulpcore#305
Required PR: pulp/pulp_file#276
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 23, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulpcore#305
Required PR: pulp/pulp_file#276
mdellweg pushed a commit to ATIX-AG/pulpcore-plugin that referenced this pull request Sep 23, 2019
This comes together with SingleArtifactContentUploadViewset.

fixes #5403
https://pulp.plan.io/issues/5403

Required PR: pulp/pulpcore#305
Required PR: pulp/pulp_file#276
@bmbouter bmbouter merged commit 4c48d6b into pulp:master Sep 27, 2019
@mdellweg mdellweg deleted the upload_create_serializer branch September 27, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants