Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Fitting directories into collection structure #299

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

fao89
Copy link
Member

@fao89 fao89 commented May 18, 2020

@pulpbot
Copy link
Member

pulpbot commented May 18, 2020

Attached issue: https://pulp.plan.io/issues/6458

tags:
- pulp
- pulpcore
- content
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an approved list of what can go here? Or is it just to ease searching?
I'd add: software-repositories, lifecycle-management, content-delivery

Copy link
Member Author

@fao89 fao89 May 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have an approved list, but these are good suggestions I'll add them

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me.

# collection label 'namespace.name'. The value is a version range
# L(specifiers,https://python-semanticversion.readthedocs.io/en/latest/#requirement-specification). Multiple version
# range specifiers can be set and are separated by ','
dependencies: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the place to include the postgres role dependency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, from the autogenerated comment I understood it is for collections rather than roles, but I'm not sure!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what i read, too. It seemd weird to me.

# The URL to the collection issue tracker
issues: https://pulp.plan.io/projects/pulp/issues?query_id=156

build_ignore:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is only supported when running ansible-galaxy collection build with Ansible 2.10 or newer.
https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/dev_guide/developing_collections.rst#ignoring-files-and-folders

Copy link
Member

@mikedep333 mikedep333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@fao89 fao89 merged commit 085e2df into pulp:master May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants