Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize project name before publish #183

Merged
merged 1 commit into from Jun 13, 2018
Merged

Conversation

werwty
Copy link
Contributor

@werwty werwty commented Jun 12, 2018

@pep8speaks
Copy link

pep8speaks commented Jun 12, 2018

Hello @werwty! Thanks for updating the PR.

Line 9:80: E501 line too long (81 > 79 characters)
Line 29:80: E501 line too long (80 > 79 characters)
Line 36:80: E501 line too long (94 > 79 characters)
Line 40:80: E501 line too long (98 > 79 characters)
Line 58:80: E501 line too long (82 > 79 characters)
Line 74:80: E501 line too long (84 > 79 characters)
Line 76:80: E501 line too long (95 > 79 characters)
Line 79:80: E501 line too long (98 > 79 characters)
Line 81:80: E501 line too long (81 > 79 characters)
Line 92:80: E501 line too long (87 > 79 characters)
Line 94:80: E501 line too long (89 > 79 characters)
Line 97:80: E501 line too long (83 > 79 characters)
Line 100:80: E501 line too long (94 > 79 characters)
Line 107:80: E501 line too long (94 > 79 characters)
Line 125:80: E501 line too long (87 > 79 characters)
Line 131:80: E501 line too long (91 > 79 characters)
Line 141:80: E501 line too long (93 > 79 characters)
Line 142:80: E501 line too long (97 > 79 characters)
Line 143:80: E501 line too long (95 > 79 characters)
Line 144:80: E501 line too long (97 > 79 characters)
Line 147:80: E501 line too long (97 > 79 characters)
Line 149:80: E501 line too long (93 > 79 characters)
Line 155:80: E501 line too long (80 > 79 characters)
Line 157:80: E501 line too long (91 > 79 characters)
Line 159:80: E501 line too long (91 > 79 characters)
Line 160:80: E501 line too long (95 > 79 characters)
Line 199:80: E501 line too long (87 > 79 characters)
Line 200:80: E501 line too long (85 > 79 characters)
Line 212:80: E501 line too long (80 > 79 characters)
Line 213:80: E501 line too long (82 > 79 characters)
Line 215:80: E501 line too long (100 > 79 characters)

Line 6:80: E501 line too long (93 > 79 characters)
Line 7:80: E501 line too long (90 > 79 characters)
Line 8:80: E501 line too long (89 > 79 characters)

Line 2:80: E501 line too long (81 > 79 characters)
Line 59:80: E501 line too long (88 > 79 characters)
Line 78:80: E501 line too long (80 > 79 characters)
Line 83:80: E501 line too long (96 > 79 characters)
Line 89:80: E501 line too long (99 > 79 characters)
Line 107:80: E501 line too long (81 > 79 characters)
Line 108:80: E501 line too long (98 > 79 characters)
Line 111:80: E501 line too long (99 > 79 characters)
Line 113:80: E501 line too long (93 > 79 characters)
Line 116:80: E501 line too long (81 > 79 characters)
Line 117:80: E501 line too long (82 > 79 characters)
Line 120:80: E501 line too long (80 > 79 characters)
Line 140:80: E501 line too long (80 > 79 characters)
Line 142:80: E501 line too long (99 > 79 characters)
Line 143:80: E501 line too long (93 > 79 characters)
Line 158:80: E501 line too long (84 > 79 characters)
Line 161:80: E501 line too long (94 > 79 characters)
Line 163:80: E501 line too long (91 > 79 characters)
Line 166:80: E501 line too long (94 > 79 characters)
Line 171:80: E501 line too long (93 > 79 characters)
Line 193:80: E501 line too long (96 > 79 characters)
Line 256:80: E501 line too long (93 > 79 characters)
Line 258:80: E501 line too long (96 > 79 characters)
Line 265:80: E501 line too long (84 > 79 characters)
Line 266:80: E501 line too long (94 > 79 characters)
Line 267:80: E501 line too long (91 > 79 characters)
Line 271:80: E501 line too long (99 > 79 characters)
Line 276:80: E501 line too long (82 > 79 characters)
Line 279:80: E501 line too long (96 > 79 characters)
Line 288:80: E501 line too long (82 > 79 characters)
Line 293:80: E501 line too long (89 > 79 characters)
Line 305:80: E501 line too long (90 > 79 characters)
Line 308:80: E501 line too long (84 > 79 characters)
Line 309:80: E501 line too long (94 > 79 characters)
Line 310:80: E501 line too long (91 > 79 characters)
Line 312:80: E501 line too long (91 > 79 characters)
Line 315:80: E501 line too long (99 > 79 characters)
Line 320:80: E501 line too long (90 > 79 characters)
Line 323:80: E501 line too long (92 > 79 characters)
Line 332:80: E501 line too long (82 > 79 characters)
Line 337:80: E501 line too long (89 > 79 characters)
Line 340:80: E501 line too long (100 > 79 characters)
Line 342:80: E501 line too long (85 > 79 characters)
Line 354:80: E501 line too long (90 > 79 characters)

Comment last updated on June 13, 2018 at 20:05 Hours UTC

@werwty werwty force-pushed the issues/3632 branch 2 times, most recently from 9f022c6 to 6aee9c1 Compare June 12, 2018 20:11
@werwty werwty added the bug Something isn't working label Jun 12, 2018


def normalize_project_name(name):
return re.sub(r"[-_.]+", "-", name).lower()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer we just used the same function as with Pulp 3, unless there is a reason otherwise.

https://github.com/pulp/pulp_python/blob/3.0-dev/pulp_python/app/tasks/publish.py#L145

@werwty werwty force-pushed the issues/3632 branch 2 times, most recently from 4ac5e41 to 923fb39 Compare June 12, 2018 20:43
@werwty werwty force-pushed the issues/3632 branch 2 times, most recently from 0d03043 to 91a567f Compare June 12, 2018 20:50
@werwty
Copy link
Contributor Author

werwty commented Jun 13, 2018

ok test

@werwty werwty force-pushed the issues/3632 branch 2 times, most recently from 12d4bb1 to 922a3d7 Compare June 13, 2018 18:55
@werwty
Copy link
Contributor Author

werwty commented Jun 13, 2018

Unit test failures are due to a known issue caused by different versions of installed pulp and unittests (one from PR the other from master). Unfortunately this is a intermittent issue and previous attempts at fixing it have broken other things: pulp/pulp-ci#525

I tested this PR locally and all unit tests pass.

@werwty werwty merged commit fabd48c into pulp:master Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants