New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize project name before publish #183
Conversation
Hello @werwty! Thanks for updating the PR.
Comment last updated on June 13, 2018 at 20:05 Hours UTC |
9f022c6
to
6aee9c1
Compare
plugins/pulp_python/plugins/utils.py
Outdated
|
||
|
||
def normalize_project_name(name): | ||
return re.sub(r"[-_.]+", "-", name).lower() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer we just used the same function as with Pulp 3, unless there is a reason otherwise.
https://github.com/pulp/pulp_python/blob/3.0-dev/pulp_python/app/tasks/publish.py#L145
4ac5e41
to
923fb39
Compare
0d03043
to
91a567f
Compare
ok test |
12d4bb1
to
922a3d7
Compare
Unit test failures are due to a known issue caused by different versions of installed pulp and unittests (one from PR the other from master). Unfortunately this is a intermittent issue and previous attempts at fixing it have broken other things: pulp/pulp-ci#525 I tested this PR locally and all unit tests pass. |
closes #3632
https://pulp.plan.io/issues/3632