Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make relative_path optional for package uploads #2440

Closed
daviddavis opened this issue Mar 25, 2022 · 0 comments · Fixed by #2537
Closed

Make relative_path optional for package uploads #2440

daviddavis opened this issue Mar 25, 2022 · 0 comments · Fixed by #2537
Assignees
@pavelpicka
Labels
Feature

Comments

@daviddavis
Copy link
Contributor

I noticed for the pulp_deb plugin, they make relative_path an optional field:

https://github.com/pulp/pulp_deb/blob/f19a0f9901a5a6bb605c3d299599157233c93ea0/pulp_deb/app/serializers/content_serializers.py#L479-L480

In fact their docs strongly advise against setting it:

https://docs.pulpproject.org/pulp_deb/workflows/upload.html#create-content-by-uploading-a-file

I was thinking pulp_rpm could also make relative_path optional on upload? Seems like there should be enough data to construct it.
@pavelpicka pavelpicka self-assigned this May 9, 2022
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 18, 2022
@pavelpicka
Optional relative_path when upload
89f5846 
User doesn't have to specify ``relative_path``.
It is generated by NVRA info from package if not specified.

closes: pulp#2440
pulp#2440
@pavelpicka pavelpicka mentioned this issue May 18, 2022
Merged
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 18, 2022
@pavelpicka
Optional relative_path when upload
fa84112 
User doesn't have to specify ``relative_path``.
It is generated by NVRA info from package if not specified.

closes: pulp#2440
pulp#2440
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 18, 2022
@pavelpicka
Optional relative_path when upload
99af4e5 
User doesn't have to specify ``relative_path``.
It is generated by NVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 18, 2022
@pavelpicka
Optional relative_path when upload
6faa1ae 
User doesn't have to specify ``relative_path``.
It is generated by NVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 19, 2022
@pavelpicka
Optional relative_path when upload
9a7461b 
User doesn't have to specify ``relative_path``.
It is generated by NVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 19, 2022
@pavelpicka
Optional relative_path when upload
321f2c1 
User doesn't have to specify ``relative_path``.
It is generated by NVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 19, 2022
@pavelpicka
Optional relative_path when upload
df6b4ad 
User doesn't have to specify ``relative_path``.
It is generated by NVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 24, 2022
@pavelpicka
Optional relative_path when upload
94f0389 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 24, 2022
@pavelpicka
Optional relative_path when upload
2975eac 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

Also remove relative_path from test.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507

[nocoverage]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 24, 2022
@pavelpicka
Optional relative_path when upload
119b86e 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

Also remove relative_path from test.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507

[nocoverage]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 24, 2022
@pavelpicka
Optional relative_path when upload
92e4bea 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

Also remove relative_path from test.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507

[nocoverage]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 24, 2022
@pavelpicka
Optional relative_path when upload
c82e693 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

Also remove relative_path from test.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507

[nocoverage]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 24, 2022
@pavelpicka
Optional relative_path when upload
a28a69e 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

Also remove relative_path from test.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507

[nocoverage]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 25, 2022
@pavelpicka
Optional relative_path when upload
8526e05 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue May 25, 2022
@pavelpicka
Optional relative_path when upload
a217118 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Jun 7, 2022
@pavelpicka
Optional relative_path when upload
be81030 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

Also remove relative_path from test.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507

[nocoverage]
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Jun 7, 2022
@pavelpicka
Optional relative_path when upload
d4b335d 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
pavelpicka added a commit to pavelpicka/pulp_rpm that referenced this issue Jun 7, 2022
@pavelpicka
Optional relative_path
117f300 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

closes: pulp#2440
pulp#2440

Require PR: pulp/pulp-cli#507
dralley pushed a commit that referenced this issue Jun 8, 2022
@pavelpicka @dralley
Optional relative_path when upload
274054d 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

Also remove relative_path from test.

closes: #2440
#2440

Require PR: pulp/pulp-cli#507

[nocoverage]
dralley pushed a commit that referenced this issue Jun 8, 2022
@pavelpicka @dralley
Optional relative_path when upload
a4b20af 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

closes: #2440
#2440

Require PR: pulp/pulp-cli#507
dralley pushed a commit that referenced this issue Jun 8, 2022
@pavelpicka @dralley
Optional relative_path
bcb4eb8 
User doesn't have to specify ``relative_path``.
It is generated by NeVRA info from package if not specified.

closes: #2440
#2440

Require PR: pulp/pulp-cli#507
@dralley dralley mentioned this issue Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavelpicka pavelpicka

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optional relative_path when upload pavelpicka/pulp_rpm
3 participants
@daviddavis @dralley @pavelpicka