-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make relative_path optional for package uploads #2440
Labels
Comments
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 18, 2022
User doesn't have to specify ``relative_path``. It is generated by NVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 18, 2022
User doesn't have to specify ``relative_path``. It is generated by NVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 19, 2022
User doesn't have to specify ``relative_path``. It is generated by NVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 19, 2022
User doesn't have to specify ``relative_path``. It is generated by NVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 19, 2022
User doesn't have to specify ``relative_path``. It is generated by NVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 24, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 24, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. Also remove relative_path from test. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507 [nocoverage]
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 24, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. Also remove relative_path from test. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507 [nocoverage]
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 24, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. Also remove relative_path from test. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507 [nocoverage]
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 24, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. Also remove relative_path from test. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507 [nocoverage]
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 24, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. Also remove relative_path from test. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507 [nocoverage]
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 25, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
May 25, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
Jun 7, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. Also remove relative_path from test. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507 [nocoverage]
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
Jun 7, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
pavelpicka
added a commit
to pavelpicka/pulp_rpm
that referenced
this issue
Jun 7, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. closes: pulp#2440 pulp#2440 Require PR: pulp/pulp-cli#507
dralley
pushed a commit
that referenced
this issue
Jun 8, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. Also remove relative_path from test. closes: #2440 #2440 Require PR: pulp/pulp-cli#507 [nocoverage]
dralley
pushed a commit
that referenced
this issue
Jun 8, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. closes: #2440 #2440 Require PR: pulp/pulp-cli#507
dralley
pushed a commit
that referenced
this issue
Jun 8, 2022
User doesn't have to specify ``relative_path``. It is generated by NeVRA info from package if not specified. closes: #2440 #2440 Require PR: pulp/pulp-cli#507
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed for the pulp_deb plugin, they make
relative_path
an optional field:https://github.com/pulp/pulp_deb/blob/f19a0f9901a5a6bb605c3d299599157233c93ea0/pulp_deb/app/serializers/content_serializers.py#L479-L480
In fact their docs strongly advise against setting it:
https://docs.pulpproject.org/pulp_deb/workflows/upload.html#create-content-by-uploading-a-file
I was thinking pulp_rpm could also make relative_path optional on upload? Seems like there should be enough data to construct it.
The text was updated successfully, but these errors were encountered: