Publish custom/unknown repository metadata #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fao89
changed the title
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 12, 2019
closes #5206 https://pulp.plan.io/issues/5206 Required PR: pulp#1418 Required PR: pulp#1427 Required PR: pulp#1440
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 13, 2019
closes #5206 https://pulp.plan.io/issues/5206 Required PR: pulp#1418 Required PR: pulp#1427 Required PR: pulp#1440
goosemania
requested changes
Sep 16, 2019
pulp_rpm/app/tasks/publishing.py
Outdated
| self.populate() | ||
| self.download_metadata_files() | ||
|
|
||
| def download_metadata_files(self): |
There was a problem hiding this comment.
Maybe prepare_metadata_files?
There was a problem hiding this comment.
I like the comment from your suggestion: Copies metadata files from the Artifact storage.
| class PublicationData: | ||
| """ | ||
| Encapsulates data relative to publication. | ||
|
|
There was a problem hiding this comment.
Please include the description of attributes (packages, repomdrecords)
pulp_rpm/app/tasks/publishing.py
Outdated
| self.repomdrecords = [] | ||
|
|
||
| self.populate() | ||
| self.download_metadata_files() |
There was a problem hiding this comment.
I would call those 2 explicitly during publication creation and not here in the init. Less magic during object instantiation and more flexibility later. What do you think?
fao89
force-pushed
the
5432
branch
2 times, most recently
from
10892b7
to
641ea77
Compare
closes #5432 https://pulp.plan.io/issues/5432 Required PR: pulp#1438 Required PR: pulp#1439
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 16, 2019
closes #5206 https://pulp.plan.io/issues/5206 Required PR: pulp#1418 Required PR: pulp#1427 Required PR: pulp#1440
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 16, 2019
closes #5206 https://pulp.plan.io/issues/5206 Required PR: pulp#1418 Required PR: pulp#1427 Required PR: pulp#1440
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 17, 2019
closes #5206 https://pulp.plan.io/issues/5206 Required PR: pulp#1418 Required PR: pulp#1427 Required PR: pulp#1440
fao89
added a commit
to fao89/pulp_rpm
that referenced
this pull request
Sep 17, 2019
closes #5206 https://pulp.plan.io/issues/5206 Required PR: pulp#1418 Required PR: pulp#1427 Required PR: pulp#1440
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5432
https://pulp.plan.io/issues/5432
Required PR: #1438
Required PR: #1439