Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring list of features up to date #1530

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Conversation

CodeHeeler
Copy link
Contributor

Add modularity and comps support to features list.
Add core-provided browseable distributions to features list.

fixes #5752
https://pulp.plan.io/issues/5752

@@ -0,0 +1,2 @@
Update docs to include modularity and comps support to features.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest to make it doc type and not misc

docs/index.rst Outdated
@@ -8,14 +8,16 @@ hosting RPM family content types.
Features
--------

* :ref:`sync-publish-workflow` with "RPM Content" including RPMs and Errata
* :ref:`sync-publish-workflow` with "RPM Content" including RPMs, Errata, Modularity, and Comps
Copy link
Member

@ipanova ipanova Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pavel is working on another docs PR that moves all errata-->advisories, so i suggest sticking to advisory term in this PR as well.

@ipanova
Copy link
Member

ipanova commented Nov 22, 2019

looks good thank you!

Copy link
Member

@ipanova ipanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i just noticed, Browsable distributions is not what you meant. You can view distributions served by pulpcore content in a browser. Here the issue for more info https://pulp.plan.io/issues/5397

docs/index.rst Outdated
@@ -8,14 +8,16 @@ hosting RPM family content types.
Features
--------

* :ref:`sync-publish-workflow` with "RPM Content" including RPMs and Errata
* :ref:`sync-publish-workflow` with "RPM Content" including RPMs, Advisories, Modularity, and Comps
* :ref:`Versioned Repositories <versioned-repo-created>` so every operation is a restorable snapshot
* :ref:`Download content on-demand <create-remote>` when requested by clients to reduce disk space.
* Upload local RPM content :ref:`easily <one-shot-upload-workflow>`
* Copy and organize RPM content into various repositories
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have copy yet, what about re-phrasing to 'Add, remove and organize...'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but as I did not write that and it is outside of this issue, should it be done in another PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in the scope of this PR. Tanya probably overlooked when writing the description of the task, in any case it is the assignee duty to thoroughly check whether the feature list is up to date with the reality.

@CodeHeeler CodeHeeler force-pushed the issue-5752 branch 3 times, most recently from d075f30 to 1f0747c Compare November 22, 2019 17:17
Add modularity and comps support to features list.
Add core-provided browseable distributions to features list.

fixes #5752
https://pulp.plan.io/issues/5752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants