Opensuse advisory support #1642
Conversation
pavelpicka
force-pushed
the
5829-opensuse-support
branch
4 times, most recently
from
3014760
to
2517848
Compare
| @@ -236,8 +236,8 @@ class UpdateCollection(BaseModel): | |||
| update_record (models.ForeignKey): The associated UpdateRecord | |||
| """ | |||
|
|
|||
| name = models.TextField() | |||
There was a problem hiding this comment.
Why nullable? Nullable textfields means you have to deal with both null or emptystring.
There was a problem hiding this comment.
opensuse doesn't use it so can be null not only empty. same as shortname
can be seen in update.xml in repo mentioned above
There was a problem hiding this comment.
How safe would it be to collapse it into an emptystring regardless?
There was a problem hiding this comment.
If it will be an empty string createrepo_c will generate empty element to xml back when publish/distribute, which I think is unnecessary
pavelpicka
force-pushed
the
5829-opensuse-support
branch
from
2517848
to
d35dc5b
Compare
|
Attached issue: https://pulp.plan.io/issues/5829 |
| @@ -185,7 +185,7 @@ class Package(Content): | |||
| # not part of createrepo_c metadata | |||
| is_modular = models.BooleanField(default=False) | |||
|
|
|||
| repo_key_fields = ('name', 'epoch', 'version', 'release', 'arch') | |||
| repo_key_fields = ('name', 'epoch', 'version', 'release', 'arch', 'location_href') | |||
There was a problem hiding this comment.
@dralley , @daviddavis? are you ok with that change until we figure out the relative path problem?
Or do you prefer to use location_href only?
There was a problem hiding this comment.
@pavelpicka can you add a comment, that createrepo_c treats src and nosrc as src, so 2 packages like pkg-1.src.rpm and pkg-1.nosrc.rpm won't be saved in a repo version unless we add location_href among repo_key fields
There was a problem hiding this comment.
Comment the explanation for easier understanding why we are adding it.
|
@pavelpicka , does it require a specific createrepo_c version? do we need to update the requirements? Why do you have |
|
@goosemania correct, I need to update requirements to createrepo_c 0.15, will check the issue if it is only one. |
pavelpicka
force-pushed
the
5829-opensuse-support
branch
from
d35dc5b
to
2215020
Compare
pavelpicka
force-pushed
the
5829-opensuse-support
branch
from
2215020
to
c978c09
Compare
pulp_rpm/app/models/package.py
Outdated
| # createrepo_c treats 'nosrc' arch (opensuse specific use) as 'src' so it can seems there are | ||
| # two same packages when their are not. By adding 'location_href' here we can recognize this. |
There was a problem hiding this comment.
...it can seem that two packages are the same when they are not.
pavelpicka
force-pushed
the
5829-opensuse-support
branch
from
c978c09
to
afcc7ca
Compare
Support for opensuse advisories. Raised createrepo_c dependecny to 0.15 version. Extend Packages' repo_key_fields w/location_href. closes #5829 https://pulp.plan.io/issues/5829
pavelpicka
force-pushed
the
5829-opensuse-support
branch
from
afcc7ca
to
40d56df
Compare
Support for opensuse advisories.
Raised createrepo_c dependecny to 0.15 version.
Extend Packages' repo_key_fields w/location_href.
closes #5829
https://pulp.plan.io/issues/5829