Fixed an issue where the value of gpgcheck wasn't set appropriately #3471
Conversation
| publication.package_checksum_type = CHECKSUM_TYPES.UNKNOWN | ||
| publication.metadata_checksum_type = CHECKSUM_TYPES.UNKNOWN | ||
| publication.repo_config = {"repo_gpgcheck": has_repomd_signature, "gpgcheck": gpgcheck} | ||
|
|
||
| for path, repo_version in repo_sync_results.items(): | ||
| add_metadata_to_publication(publication, repo_version, prefix=path) |
There was a problem hiding this comment.
I also think we were re-setting these values over and over again for repositories with .treeinfo, and the end result values might have ended up being incorrect as a result. We want to consider the parent repo only.
|
Working on a test |
dralley
force-pushed
the
repo-config
branch
5 times, most recently
from
8245e64
to
670581c
Compare
| @@ -577,6 +571,15 @@ def is_subrepo(directory): | |||
| with RpmPublication.create( | |||
| repo_sync_results[PRIMARY_REPO], pass_through=False | |||
| ) as publication: | |||
| gpgcheck = repository.repo_config.get("gpgcheck", 0) | |||
| has_repomd_signature = ( | |||
There was a problem hiding this comment.
I wonder if instead of looking at .asc file we should be fetching the repo_gpgcheck from repository.repo_config?
There was a problem hiding this comment.
How about: if it's enabled and the .asc exists then we enable it, if either is false then we disable it.
dralley
force-pushed
the
repo-config
branch
5 times, most recently
from
43ca85a
to
c71ee2b
Compare
On publications created by `mirror_complete` sync. closes pulp#3462
Backport to 3.25: 💚 backport PR created✅ Backport PR branch: Backported as #3474 🤖 @patchback |
On publications created by
mirror_completesync.closes #3462