1042932 - Update to use the step processor for exporting repos and repo ... #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: plugins/pulp_rpm/plugins/distributors/yum/distributor.py plugins/pulp_rpm/plugins/distributors/yum/publish.py plugins/test/unit/plugins/distributors/yum/test_distributor.py
|
Looks good. Can't believe this was faster than the 13 file pulp one. I guess because of more deletions and less additions :). I haven't been able to check the test coverage thoroughly on both of these, but I am guessing you have run it through coverage report. If so, merge away. |
barnabycourt
added a commit
that referenced
this pull request
May 16, 2014
1042932 - Update to use the step processor for exporting repos and repo ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...groups
BZ: pulp/pulp#964