This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
1042932- Move common publish steps to the platform and update publish st... #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… steps to support nesting steps
|
|
||
| PUBLISH_STEP_DIRECTORY = u'publish_directory' | ||
| PUBLISH_STEP_TAR = u'save_tar' | ||
| PUBLISH_STEP_COPY_DIRECTORY = u'copy_directory' |
There was a problem hiding this comment.
Why are we using unicode identifiers in these constants?
There was a problem hiding this comment.
Because the constants are used for comparing against items that have been put in the database where they are converted to unicode even if they start as a regular string. It is easier to start with unicode and then comparisons work fine in either direction.
|
Except for minor corrections / typos, LGTM. |
barnabycourt
added a commit
that referenced
this pull request
May 16, 2014
1042932- Move common publish steps to the platform and update publish st...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...eps to support nesting steps
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1042932