1183784 - clean hosting directories on repo distributor delete #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # remove certificates for certificate based auth | ||
| configuration.remove_cert_based_auth(repo, config) | ||
|
|
||
| def clean_simple_hosting_directories(self, start_location, containing_dir): | ||
|
|
|
This PR is missing the detailed unit tests of the logic for the clean_simple_hosted_directories method. All it is doing is ensuring that the method is called. |
|
@barnabycourt, fixed based on PR comments, read for re-review. |
| # remove the directory. It is possible that the concurrent operation created the | ||
| # listing file before this operation deleted it, so to be safe, we need to | ||
| # regenerate the listing file. | ||
| util.generate_listing_files(up_dir, up_dir) |
There was a problem hiding this comment.
It does not appear that this code path is covered in the unit test
|
one other code path that should be covered in the unit tests but otherwise LGTM |
asmacdo
force-pushed
the
1183784-dev
branch
2 times, most recently
from
4b585a4
to
f891e20
Compare
asmacdo
added a commit
that referenced
this pull request
Feb 20, 2015
1183784 - clean hosting directories on repo distributor delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When repos are deleted, the simple hosting directory structure that matches their relative url is not cleaned up, which leaves the opportunity to conflict with sub-urls of deleted repos.
BZ-1183784
This patch cleans up this directory structure when a repo is deleted. There is also a migration to clean already existing orphaned directories.