Fixes related to units_erratum.pushcount field #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pulp-smash at b9069643f7a5759ff8675cdfe4e131c750681184 passes for me on 2.8 with the same problems as the commit message indicates are expected. The failures that prompted the issue (see ticket) now work. |
| The database has renamed some field names for RPM unit models. This change should not be noticeable through the API, | ||
| but it does come with a migration which drops some indexes. The following field names are renamed: | ||
| The 2.8.0 comes with strong Validation enabled at the database layer. This required some database | ||
| changes to be, however these should go unnoticed for most users. For those integrating with Pulp |
There was a problem hiding this comment.
missing a verb after "to be" ?
bmbouter
force-pushed
the
1455-Mild
branch
2 times, most recently
from
247aa60
to
d455942
Compare
* Reverts units_erratum.pushcount to be an StringField * Adds migration 24 which converts all int or float units_erratum.pushcount values to a string. Any pushcount fields with a value of null are $unset. * Adds tests for migration 24 * Adds release notes about field data quality changes * Adjusts pulp-admin to have it submit pushcount as a string https://pulp.plan.io/issues/1455 closes pulp#1455
bmbouter
added a commit
that referenced
this pull request
Dec 23, 2015
Fixes related to units_erratum.pushcount field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
units_erratum.pushcount values to a string
https://pulp.plan.io/issues/1455
closes #1455