Save modifications to the erratum pkglist before adding new collections. #869
Conversation
| # collections in the pkglist in the database before new collections will be added to | ||
| # the pkglist, because mongoengine does not allow to modify existing items in the list | ||
| # and add new items to the list at the same time. | ||
| self.save() |
There was a problem hiding this comment.
Because of this change, I propose the function name change from merge_pkglists to merge_pkglists_and_save. This will more accurately capture the new side-effect this introduces.
Also does it make sense to have an additional save() after L#777 so that the final state is also saved? I think it would be good but you would know better than I about that. Since the function is providing a save() functionality we should have it save() the final state also and not just the partial state. What do you think?
There was a problem hiding this comment.
I was concerned about this partial state, but even adding another save() at the end of this method is still the partial update of the erratum, but it can be a final state for merging pkglists.
There was a problem hiding this comment.
Adding the additional save() would be good for the reason you mention in your comment.
|
I'm adding a LGTM because I don't need to re-review. Please do making the additional Good fix! 🌴 😄 🐈 |
It is needed because mongoengine does not allow to modify items in the list and to add a new ones to the list at the same time. And sometimes we are in this situation during the update of the erratum. closes pulp#1910 https://pulp.plan.io/issues/1910
|
ok test |
It is needed because mongoengine does not allow to modify items in
the list and to add a new ones to the list at the same time.
And sometimes we are in this situation during the update of the erratum.
closes #1910
https://pulp.plan.io/issues/1910