Skip to content

Commit

Permalink
Add warning that REST API is not safe for multi-user use
Browse files Browse the repository at this point in the history
  • Loading branch information
goosemania committed May 26, 2020
1 parent 8817d13 commit 8c3a6da
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 1 deletion.
6 changes: 5 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ Changelog
To add a new change log entry, please see
https://docs.pulpproject.org/contributing/git.html#changelog-update
WARNING: Don't drop the next directive!
WARNING: Don't drop the towncrier directive!

.. warning::
Until Role-Based Access Control is added to Pulp, REST API is not safe for multi-user use.
Sensitive credentials can be read by any user, e.g. ``Remote.password``, ``Remote.client_key``.

.. towncrier release notes start
Expand Down
1 change: 1 addition & 0 deletions CHANGES/6692.doc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Added a warning that the REST API is not safe for multi-user use until RBAC is implemented.
3 changes: 3 additions & 0 deletions docs/components.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ things:

$ pulpcore-manager runserver 24817

.. warning::
Until Role-Based Access Control is added to Pulp, REST API is not safe for multi-user use.
Sensitive credentials can be read by any user, e.g. ``Remote.password``, ``Remote.client_key``.

The REST API can be deployed with any any WSGI webserver like a normal Django application. See the
`Django deployment docs <https://docs.djangoproject.com/en/2.1/howto/deployment/wsgi/>`_ for more
Expand Down
3 changes: 3 additions & 0 deletions docs/installation/authentication.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ username and password against the internal users database.
This authentication is only for the REST API. Client's fetching binary data have their identity
verified and authorization checked using a :term:`ContentGuard`.

.. warning::
Until Role-Based Access Control is added to Pulp, REST API is not safe for multi-user use.
Sensitive credentials can be read by any user, e.g. ``Remote.password``, ``Remote.client_key``.

Which URLs Require Authentication?
----------------------------------
Expand Down
3 changes: 3 additions & 0 deletions docs/rest_api.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ REST API

The REST API documentation is `here <restapi.html>`_.

.. warning::
Until Role-Based Access Control is added to Pulp, REST API is not safe for multi-user use.
Sensitive credentials can be read by any user, e.g. ``Remote.password``, ``Remote.client_key``.

The documentation is auto generated based on the OpenAPI schema for the REST API. The hosted
documentation is broken up between ``pulpcore`` and each of the plugin's documentation sites.
Expand Down

0 comments on commit 8c3a6da

Please sign in to comment.