Fix error when listing repo version while running orphan cleanup #1681
Conversation
gerrod3
force-pushed
the
repo_ver_content_href
branch
from
88aeff4
to
f7a66c6
Compare
|
Attached issue: https://pulp.plan.io/issues/9481 |
gerrod3
force-pushed
the
repo_ver_content_href
branch
from
f7a66c6
to
c44e79c
Compare
gerrod3
force-pushed
the
repo_ver_content_href
branch
2 times, most recently
from
f989a28
to
5b03531
Compare
| ctype_query = Content.objects.filter( | ||
| pulp_type=self.content_type, pk__in=repository_content.values_list("content", flat=True) | ||
| ) | ||
| ctype_model = ctype_query.first().cast().__class__ |
There was a problem hiding this comment.
The docstring of this function doesn't match what it is doing (or what it was doing previously, to be fair). Could you update it to convey the requirement that it be capable of handling the types of content "removed" from the repository version as well?
There was a problem hiding this comment.
There was a problem hiding this comment.
"present" is the misleading term
gerrod3
force-pushed
the
repo_ver_content_href
branch
from
5b03531
to
daec1b0
Compare
pulpcore/app/models/repository.py
Outdated
| For each content type present in the RepositoryVersion, create the URL of the viewset of | ||
| that variety of content along with a query parameter which filters it by presence in this | ||
| RepositoryVersion. | ||
| For each content type that is or was apart of the RepositoryVersion, create the URL of the |
There was a problem hiding this comment.
that is present in or removed from this RepositoryVersion
gerrod3
force-pushed
the
repo_ver_content_href
branch
from
daec1b0
to
df6c0ee
Compare
|
Just tested this patch by manually making the changes on |
fixes: #9481
Since orphan cleanup became a non-blocking task it was possible for this query to "return'"
Noneif the firstContentwas deleted before thecastcall was completed. Now it should use aContentobject that is apart ofRepositoryVersion.Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html