Fixes PulpImport in the presence of Django path-traversal CVE fix. #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggainey
force-pushed
the
9660_import_save
branch
from
e136de0
to
afc2f76
Compare
|
Attached issue: https://pulp.plan.io/issues/9660 |
goosemania
reviewed
Jan 4, 2022
| with open(src, "rb") as f: | ||
| default_storage.save(dest, f) | ||
| default_storage.save(base_path, f) |
dralley
approved these changes
Jan 4, 2022
dkliban
approved these changes
Jan 4, 2022
goosemania
added a commit
to goosemania/pulp_rpm
that referenced
this pull request
Jan 5, 2022
*** WARNING *** DO NOT try to PATCH your system with these changes. This fix contains a database migration. It's hard to revert the changes. You will BREAK YOUR UPGRADE PATH if you use this patch. *************** closes pulp#2305 (was redmine 9583) Required PR: pulp/pulpcore#1791
ggainey
force-pushed
the
9660_import_save
branch
3 times, most recently
from
96a8e47
to
1d25cf8
Compare
Fixes #9660. [nocoverage]
ggainey
force-pushed
the
9660_import_save
branch
from
1d25cf8
to
7ad8335
Compare
fao89
approved these changes
Jan 5, 2022
goosemania
approved these changes
Jan 5, 2022
|
I pressed the wrong button, apologies. This can be merged without waiting for CI to finish. |
goosemania
added a commit
to pulp/pulp_rpm
that referenced
this pull request
Jan 5, 2022
*** WARNING *** DO NOT try to PATCH your system with these changes. This fix contains a database migration. It's hard to revert the changes. You will BREAK YOUR UPGRADE PATH if you use this patch. *************** closes #2305 (was redmine 9583) Required PR: pulp/pulpcore#1791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9660.
[nocoverage]