Convert remaining CharField to TextField #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
field-retype
branch
4 times, most recently
from
3fb92dc
to
7d435cb
Compare
CodeHeeler
approved these changes
Nov 12, 2019
dev_requirements.txt
Outdated
| @@ -5,3 +5,4 @@ ipython | |||
| codecov | |||
| coverage | |||
| flake8 | |||
| pytest | |||
There was a problem hiding this comment.
Did you mean to make this change as part of this same PR?
dralley
force-pushed
the
field-retype
branch
3 times, most recently
from
86ef34c
to
787c5c1
Compare
daviddavis
approved these changes
Nov 12, 2019
dralley
force-pushed
the
field-retype
branch
2 times, most recently
from
4358c0e
to
0ed5848
Compare
daviddavis
reviewed
Nov 12, 2019
pulpcore/app/models/progress.py
Outdated
| @@ -106,7 +106,7 @@ class ProgressReport(Model): | |||
| it will be set to the current task_id. | |||
| """ | |||
| message = models.TextField() | |||
| code = models.CharField(max_length=36) | |||
| code = models.TextField() | |||
There was a problem hiding this comment.
Why remove the max_length here? I thought code was supposed to be a short name for the progress report.
There was a problem hiding this comment.
Sure, but how do we decide how short is too short? I feel like we should just make sure plugin writers know they need to keep it short by convention. I can revert it for now though, if it limits plugin writers too much we can increase it or change it.
dralley
force-pushed
the
field-retype
branch
from
0ed5848
to
8e8dcb8
Compare
daviddavis
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5609
https://pulp.plan.io/issues/5609
Exception, the artifact hashes have a preset length. While we don't gain (or lose) anything from using CharField, it might provide a little tiny amount of extra validation, so I left it as-is.