Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a significant memory leak #4090

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix a significant memory leak #4090

merged 1 commit into from
Jul 20, 2023

Conversation

dralley
Copy link
Contributor

@dralley dralley commented Jul 19, 2023

Which occurs when making repeated large queries against the API service. The cache unintentionally was holding references to entire instances of views, which are substantial.

closes #2250

@dralley dralley requested review from gerrod3 and ggainey July 19, 2023 19:35
@dralley
Fix a significant memory leak
fb96a8b 
Which occurs when making repeated large queries against the API service.
The cache unintentionally was holding references to entire instances of
views, which are substantial.

closes pulp#2250
@dralley
Copy link
Contributor Author

dralley commented Jul 19, 2023 •
edited
Loading

Thanks @hao-yu and Peter for the discovery and @gerrod3 for doing additional investigation!

ggainey
ggainey approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@ggainey ggainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are all green and the discussion makes sense - approving, good job all!

@dralley dralley requested a review from mdellweg July 20, 2023 02:00
@gerrod3
Copy link
Contributor

gerrod3 commented Jul 20, 2023

Can we re-open old issues? This change will be a regression on this old issue: #2802. Not the biggest deal and more preferred then having memory leaks, but it will be something we want to track.

@dralley
Copy link
Contributor Author

dralley commented Jul 20, 2023

Can we re-open old issues? This change will be a regression on this old issue: #2802. Not the biggest deal and more preferred then having memory leaks, but it will be something we want to track.

Sure, fine with me. Maybe first we should check up with @gmbnomis and see if it still regresses?

@mdellweg
Copy link
Member

Can we re-open old issues? This change will be a regression on this old issue: #2802. Not the biggest deal and more preferred then having memory leaks, but it will be something we want to track.

Since we fixed that issue, I think we should open a new one...

@dralley dralley merged commit 73f5e37 into pulp:main Jul 20, 2023
15 checks passed
@patchback
Copy link

patchback bot commented Jul 20, 2023 •
edited
Loading

Backport to 3.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.18/73f5e37bc6121d8afba6786ac5338cb8e46fec2a/pr-4090

Backported as #4094

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jul 20, 2023
Closed
@patchback
Copy link

patchback bot commented Jul 20, 2023 •
edited
Loading

Backport to 3.21: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.21/73f5e37bc6121d8afba6786ac5338cb8e46fec2a/pr-4090

Backported as #4095

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jul 20, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 20, 2023 •
edited
Loading

Backport to 3.22: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.22/73f5e37bc6121d8afba6786ac5338cb8e46fec2a/pr-4090

Backported as #4096

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jul 20, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 20, 2023 •
edited
Loading

Backport to 3.23: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.23/73f5e37bc6121d8afba6786ac5338cb8e46fec2a/pr-4090

Backported as #4097

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jul 20, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 20, 2023 •
edited
Loading

Backport to 3.29: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.29/73f5e37bc6121d8afba6786ac5338cb8e46fec2a/pr-4090

Backported as #4098

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jul 20, 2023
Merged
@dralley dralley mentioned this pull request Jul 20, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 25, 2023 •
edited
Loading

Backport to 3.28: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.28/73f5e37bc6121d8afba6786ac5338cb8e46fec2a/pr-4090

Backported as #4129

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jul 25, 2023
Merged
jctanner added a commit to jctanner/galaxy_ng that referenced this pull request Jul 26, 2023
@jctanner
Remove lru caching on get_access_policy for memory performance concerns.
9bba1b8 
pulp/pulpcore#4090

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@jctanner jctanner mentioned this pull request Jul 26, 2023
Merged
jctanner added a commit to ansible/galaxy_ng that referenced this pull request Jul 26, 2023
@jctanner
Remove lru caching on get_access_policy for memory performance concer…
65757a9 
…ns. (#1817)

pulp/pulpcore#4090

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@wbclark wbclark mentioned this pull request Aug 7, 2023
Closed
@ekohl ekohl mentioned this pull request Sep 25, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggainey ggainey ggainey approved these changes

@mdellweg mdellweg mdellweg approved these changes

@gerrod3 gerrod3 Awaiting requested review from gerrod3

Assignees
No one assigned
Labels
backport-3.21 backport-3.22
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gunicorn consuming excessive amounts of memory
4 participants
@dralley @gerrod3 @mdellweg @ggainey