Relax max_requests #295
Relax max_requests #295
Conversation
| Integer[0] $api_service_worker_max_requests = 50, | ||
| Integer[0] $api_service_worker_max_requests_jitter = 30, | ||
| Integer[0] $api_service_worker_max_requests = 800, | ||
| Integer[0] $api_service_worker_max_requests_jitter = 100, |
There was a problem hiding this comment.
These seem reasonable to me, but they're just spitballs. Probably 4,000 and 500 would be fine too.
Out of interest: can you share a link? |
|
Thanks. How one line can make such a big difference. That looks very recent so I'd like to see it propagate through packaging. It also needs updated tests to reflect the new numbers. |
|
I believe the tests are testing changing those values rather than the current values, so they don't need to be changed. Unless you mean something else. |
|
Oh, there's tests that weren't added in the previous PR that I missed. |
The root cause of the memory leak has been established and resolved, so these aggressive values are no longer necessary
|
@ekohl Pushed |
|
https://ci.theforeman.org/job/pulpcore-3.22-rpm-pipeline/ is still blocked (there was some issue in CentOS CI) and I'd like to wait for that to pass. |
The root cause of the memory leak has been established and resolved, so these aggressive values are no longer necessary