Make pytest plugin resiliant to missing bindings #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
lazy_fixtures
branch
from
9c3b363
to
3582493
Compare
mdellweg
commented
Dec 8, 2023
| _api_client_set.remove(pulpcore_client) | ||
|
|
||
|
|
||
| # TODO Deprecate all the api_client fixtures below. |
There was a problem hiding this comment.
I hope, we can get a lot of boilerplate out of the way here.
mdellweg
force-pushed
the
lazy_fixtures
branch
2 times, most recently
from
26f39ee
to
cb993ee
Compare
mdellweg
added a commit
to mdellweg/pulpcore
that referenced
this pull request
Dec 11, 2023
This also provides new pulpcore_bindings and file_bindings fixtures that will provide all the bindings apis preconfigured. fixes pulp#4851
mdellweg
force-pushed
the
lazy_fixtures
branch
from
cb993ee
to
0ae5229
Compare
mdellweg
added a commit
to mdellweg/pulpcore
that referenced
this pull request
Dec 11, 2023
This also provides new pulpcore_bindings and file_bindings fixtures that will provide all the bindings apis preconfigured. fixes pulp#4851
mdellweg
force-pushed
the
lazy_fixtures
branch
from
0ae5229
to
08f17dc
Compare
mdellweg
added a commit
to mdellweg/pulpcore
that referenced
this pull request
Dec 11, 2023
This also provides new pulpcore_bindings and file_bindings fixtures that will provide all the bindings apis preconfigured. fixes pulp#4851
mdellweg
force-pushed
the
lazy_fixtures
branch
2 times, most recently
from
d0a5ef5
to
80c8d8d
Compare
mdellweg
commented
Dec 11, 2023
| """ | ||
| A namespace providing preconfigured pulpcore api clients. | ||
|
|
||
| e.g. `pulpcore_bindings.WorkersApi.list()`. |
There was a problem hiding this comment.
This will also bring us away from the questionable practice of giving these apis new names. (I mean the generated names are not always great, but they are there to be anyway.)
dralley
reviewed
Dec 11, 2023
|
|
||
| gpg = gnupg.GPG(gnupghome=signing_gpg_homedir_path) | ||
|
|
||
| gpg.import_keys(private_key_data) | ||
| gpg.import_keys(response.content) |
mdellweg
force-pushed
the
lazy_fixtures
branch
7 times, most recently
from
e127d70
to
c967512
Compare
mdellweg
force-pushed
the
lazy_fixtures
branch
3 times, most recently
from
c050737
to
f6eeadc
Compare
gerrod3
reviewed
Dec 14, 2023
Comment on lines
+602
to
+605
| def _proxy_module(): | ||
| import proxy | ||
|
|
||
| return proxy |
There was a problem hiding this comment.
Should this be a session fixture?
| """ | ||
| Wait for a task to reach a final state. | ||
|
|
||
| Returns the task in "completed" state, or throws a `PulpTaskTimeoutError` in case the timeout | ||
| in seconds (defaulting to 30*60) exceeded or a `PulpTaskError` in case it reached any other | ||
| final state. | ||
| """ | ||
| from pulpcore.client.pulpcore import ApiException |
There was a problem hiding this comment.
If the bindings are in pulpcore_bindings then I don't think we need this import.
|
|
||
| def __getattr__(self, name): | ||
| # __getattr__ is only consulted if nothing is found in __dict__. | ||
| assert name.endswith("Api") |
There was a problem hiding this comment.
The only problem with this assert is that the API classes can have custom names if the view is using drf_spectacular.
There was a problem hiding this comment.
Do you have an example?
I can remove it...
There was a problem hiding this comment.
@gerrod3 I have yet to see one example...
mdellweg
force-pushed
the
lazy_fixtures
branch
2 times, most recently
from
8820a61
to
67c44e2
Compare
gerrod3
reviewed
Dec 15, 2023
mdellweg
force-pushed
the
lazy_fixtures
branch
from
67c44e2
to
70e419c
Compare
This also provides new pulpcore_bindings and file_bindings fixtures that will provide all the bindings apis preconfigured. fixes pulp#4751
mdellweg
force-pushed
the
lazy_fixtures
branch
from
70e419c
to
54dcd7a
Compare
dkliban
approved these changes
Jan 9, 2024
bmbouter
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should eventually make the pytest plugins more lightweight until actually used, and prevent import errors, when bindings that are not supposed to be used are not installed.