-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new approach to binding fixtures #3468
Comments
The only thing to hold you back is that this might be an unwarranted request to bump the pulpcore dependency. |
I'm not sure if I understand why it would cause an unwarranted bump request. Do you mean it would require pulpcore bumping because we would import But anyway, any good plan to get around that? |
You nailed it. That's exactly what i was pointing at. Is it a good idea to require more recent pulpcore in order to use more recent testing features only? And maybe it is. |
I really can't tell if its a good idea or not. But to avoid the risk of any trouble this might cause, how about just copying BindingNamespace over? Assuming it is the only dependency required, it's a very simple one. |
We're already using the new pulpcore bindings fixtures after pulpcore 3.55 bump (here), so I guess its safe to proceed with this. |
I would like to have a similar bindings API as we have now in pulpcore (after this change).
As a developer, this approach feels more ergonomic. Other benefits should be equivalent to those discussed in the linked PR.
The text was updated successfully, but these errors were encountered: