Add child tasks for processing repo version imports #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached issue: https://pulp.plan.io/issues/6484 |
|
Grabbed the PR and ran it through my test-harness. In general, everything is working and the child tasks are reporting as I'd expect, and the code looks reasonable to me. The one suggestion I was going to make is "it would be nice if the parent task had a summary of the children so I don't have to go look at them individually" - which, as it turns out, is exactly what 6559 is opened to address! So I'm good with this change. |
bmbouter
reviewed
Apr 24, 2020
bmbouter
reviewed
Apr 24, 2020
dkliban
approved these changes
Apr 24, 2020
bmbouter
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
This addresses the two concerns I had also. It looks good to me. Thanks @daviddavis ! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6484
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html