-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove customized operation_id from OrphansView #882
Conversation
Attached issue: https://pulp.plan.io/issues/7446 |
Does this result in a change of of the api.json? If yes, can you outline how? |
From:
to
|
Than it is breaking the way we are consuming the api. Atm, it falls in line with all the other operationId's: Sorry i need to NACK this. |
|
path = "/".join(tokenized_path).replace("pulp/api/v3/", "") | ||
tokenized_path = path.split("/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I fixed what you meant @mdellweg
(pulp) [vagrant@pulp3-source-fedora31 html]$ curl -o api.json "http://localhost:24817/pulp/api/v3/docs/api.json"
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 940k 100 940k 0 0 2229k 0 --:--:-- --:--:-- --:--:-- 2224k
(pulp) [vagrant@pulp3-source-fedora31 html]$ cat api.json | jq '.paths[][]|.operationId' | grep orphan
"orphans_delete"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks much better.
a52dddc
to
3908276
Compare
def delete_orphans(): | ||
"""Delete orphans through bindings.""" | ||
response = OrphansApi(core_client).delete() | ||
monitor_task(response.task) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkliban this was the fix for the S3 issue
https://pulp.plan.io/issues/7446
closes #7446
Please be sure you have read our documentation on creating PRs:
https://docs.pulpproject.org/contributing/pull-request-walkthrough.html