Problem: ssl fields on remote are hard to use #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkliban
force-pushed
the
ssl-fields
branch
3 times, most recently
from
c9e004b
to
fc80217
Compare
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
=========================================
+ Coverage 67.79% 67.8% +0.01%
=========================================
Files 65 65
Lines 3018 3019 +1
=========================================
+ Hits 2046 2047 +1
Misses 972 972
Continue to review full report at Codecov.
|
Solution: switch all ssl fields to TextField This patch switches the storage of SSL certs, keys, and CAs from filesystem to database. This patch also introduces a new serializer field that returns a SHA256 digest for GET operations. Required PR: pulp/pulpcore-plugin#91 fixes: pulp#4506 https://pulp.plan.io/issues/4506 re: pulp#4676 https://pulp.plan.io/issues/4676
bmbouter
reviewed
Apr 26, 2019
| @@ -1,5 +1,6 @@ | |||
| from gettext import gettext as _ | |||
| import os | |||
| import hashlib | |||
bmbouter
reviewed
Apr 26, 2019
| @@ -209,3 +210,14 @@ def to_representation(self, value): | |||
| prefix.strip('/'), | |||
| base_path.lstrip('/') | |||
| )) | |||
|
|
|||
|
|
|||
| class SecretCharField(serializers.CharField): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: switch all ssl fields to TextField
This patch switches the storage of SSL certs, keys, and CAs from filesystem to
database. This patch also introduces a new serializer field that returns a SHA256
digest for GET operations.
Required PR: pulp/pulpcore-plugin#91
Fixes: #4506
https://pulp.plan.io/issues/4506
Re: #4676
https://pulp.plan.io/issues/4676