This repository has been archived by the owner on May 19, 2023. It is now read-only.
Fix all Tests #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been a few PRs made to this repo while we had the broken tester.
This ended up resulting in many PRs being made that ended up breaking our tests. Most of these related to rebranding, without every resolving the tests that would check on those strings.
So this PR goes ahead and fixes any of those issues, while also finishing up the rebrand work throughout the whole package. Including some cases where wrong Pulsar APIs were being used, and brings those to the right usage. If all tests pass here and things are good then we can merge and get this repo bundling with the core finally. (After looking at that last open PR here)