Decaffeinate install spec #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was mostly handwork, comparing the decaf output and GuilleW's decaffeinated file from earlier. `let` changes, varargs, arrow functions, comments were all good to go
12 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is meant to supersede #32 but it wasn't that much a mechanic task.
There have been upstream changes, and the complexity of the code did show: the former caffeination showed some archaic structures (like the
argumentsmagic argument that needs to be upgraded to an Array). Also, quite a lot of comments were missing in it so what I did was more or less a review in itself, keeping good changes and reverting obsolete ones while making sure nothing gets lost.