Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed base16 url to use wayback machine #121

Merged
merged 1 commit into from Nov 10, 2022
Merged

changed base16 url to use wayback machine #121

merged 1 commit into from Nov 10, 2022

Conversation

sertonix
Copy link
Contributor

@sertonix sertonix commented Nov 7, 2022

The url http://chriskempson.com redirects to another page and not the original. I used the wayback machine to add the original pages

@Daeraxa
Copy link
Member

Daeraxa commented Nov 7, 2022

Maybe we should link to the updated places (as well)?
e.g. https://github.com/chriskempson/base16 and https://github.com/chriskempson/tomorrow-theme

confused-Techie
confused-Techie approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks fantastic to me, and great find on locating it on WayBack Machine. This is what should happen to outdated links whenever possible

@mauricioszabo mauricioszabo merged commit fa6ee9d into pulsar-edit:master Nov 10, 2022
@sertonix sertonix deleted the base-16-wayback-url branch November 13, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confused-Techie confused-Techie confused-Techie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sertonix @Daeraxa @confused-Techie @mauricioszabo