Resolve all Tests within language-html (Resolves 2 Failing Tests)
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to PR #299
language-htmlhad somescopeSelectorsthat would manually check what version of Pulsar was being run.And if prior to
1.21would use an old style ofscopeSelectors. Which now that we are on version1.100.0was being reported as true, causing the tests to use the old style ofscopeSelectorwhich would cause the test to fail.Much more detail is on the linked PR, but this resolves these tests in the same exact way. Remove the older
scopeSelectorstyle support, sticking with the newer style. Which can still be updated if/when needed. But otherwise gets two more passing tests into the language testing bundle.