Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump github to v0.36.16-pretranspiled #592

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Jun 15, 2023

Bumps the "github" package.

Comparison: pulsar-edit/github@v0.36.15-pretranspiled...v0.36.16-pretranspiled

Includes these PR's over at the github package's own repo:

One of these is end-user-facing. It adds a menu item under "Packages > GitHub > Log Out" that logs you out of the GitHub package / GitHub integration bits of Pulsar. See PR 27 over there for details. The other one is CI only, and shouldn't make a direct difference to the code/package itself.

@DeeDeeG DeeDeeG requested a review from a team June 16, 2023 00:13
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I know there are some CI failures, but if they occur only on ARM Linux, then we should be good to go

@confused-Techie
Copy link
Member

Merging with just ARM failing

@confused-Techie confused-Techie merged commit 9525f5b into master Jun 16, 2023
99 of 100 checks passed
@confused-Techie confused-Techie deleted the bump-github-package branch June 16, 2023 01:41
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Jun 16, 2023

For context we're pretty sure this is a CI side or CDN problem? electron-builder failing to download zip files and other binaries off of GitHub/AWS?? Seems like maybe we can hope this one just goes away from the infra provider folks fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants