[meta] Install Python package setuptools && Use Python 3.12.x
#779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
confused-Techie
changed the title
3.11.5 on all build Platformssetuptools && Use Python 3.12.x
DeeDeeG
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
I guess there's not much to review here.
If this makes node-gyp not error out, it's great.
This should not have been happening on Python older than 3.12 -- if they really removed distutils in a patch release 3.11.6, consider my flabber summarily gasted.
Approve, it seems to pass CI, and this is a CI problem, so like that's 100% of what counts, for now.
|
Thanks a ton for the review @DeeDeeG |
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seeing failures to build PPM on Windows after the new version of Python
3.11.6, claimingdistutilscannot be found (Just like we see and know has been removed on Python3.12.x)So in an attempt to fix this I'm pinning Python to3.11.5on all build platforms in an attempt to fix this.But this does raise another question: Why doesn't our CI tell us it failed on this step?
EDIT:
So seems this was actually fixed by installing the Python package
setuptoolsas recommended in the Python changelog. This package paired with Python3.12.xseems to have been able to successfully build on every platform. Hopefully putting an end to each Python version breaking something (For the time being)