Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add non-macOS keybindings for fuzzy-finder readme #796

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

Daeraxa
Copy link
Member

@Daeraxa Daeraxa commented Nov 7, 2023

The description of the fuzzy-finder package only references macOS keybindings, this PR adds the Linux/Windows equivalent.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! While one of our CI is failing here, we know the exact cause, it is now fixed, and this is a readme only change, so I think we are safe to merge anyway

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ran the last failing package test find-and-replace just to be safe, it passed this time.

As others have noted, this is just a readme-only change, so seems pretty dang safe. I expect this to pass the Editor tests on master branch with the fix from #795.

Merging!

@DeeDeeG DeeDeeG merged commit be8bd83 into pulsar-edit:master Nov 7, 2023
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants