Return to original logic for ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT

[savetheclocktower]

Identify the Bug

In macOS or Linux, with an already-open instance of Pulsar, use your shell to change to an atypical directory, then run pulsar .. When the window opens, open the dev tools, then run process.env.PWD in the shell. The returned value will be /, rather than the directory from which you invoked pulsar.

This might also manifest when Pulsar is launched from scratch; not sure.

Description of the Change

This change seems to be the culprit. (I think it just assigns ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT rather than exporting it, but I try not to know too much about bash for fear that I might one day be asked to write some.) So I reverted it, or at least the part having to do with ATOM_DISABLE_SHELLING_OUT_FOR_ENVIRONMENT.

Alternate Designs

Nah, better to go with something tried and true.

Possible Drawbacks

Can’t think of any.

Verification Process

This was hard to verify because pulsar is symlinked to your app path (in my case, /Applications/Pulsar.app/Contents/Resources/pulsar.sh) and the script assumes it’ll be run in that context. But you can temporarily define the variables in your shell…

export PULSAR_PATH="/Applications"
export ATOM_APP_NAME="Pulsar.app"

…or the equivalents on Linux. Then you can run pulsar.sh directly from its location in your local copy of the repo. You can then repeat the steps from above and verify that process.env.PWD matches the directory you launched Pulsar from.

Release Notes

• Fixed an issue that prevented Pulsar from inheriting the directory from which the pulsar binary was run.

[DeeDeeG]

Haven't tested this myself yet, but the explanation of "exporting vs simply setting a variable" making a difference in unexpected ways is definitely believable. From experience this has turned out to be the issue a lot of the time.

[confused-Techie]

This looks great! And review is a no brainer, since comparing to the original diff of this file, we can see things are more just back to how they were.

Thanks for putting this one together, and lets get this one merged!