Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add PRIMA prototypes #188

Merged
merged 18 commits into from
May 29, 2020
Merged

Conversation

mbeyeler
Copy link
Member

@mbeyeler mbeyeler commented May 27, 2020

  • Add the different PRIMA generations
    • PRIMA: 100um, used in clinical trial
    • PRIMA75: 75um pixel pitch
    • PRIMA55: 55um pixel pitch
    • PRIMA40: 40um pixel pitch
  • HexElectrode, PhotovoltaicPixel
  • Add references
  • Gallery example

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #188 into master will increase coverage by 0.83%.
The diff coverage is 95.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   89.16%   90.00%   +0.83%     
==========================================
  Files          69       69              
  Lines        5401     5620     +219     
==========================================
+ Hits         4816     5058     +242     
+ Misses        585      562      -23     
Flag Coverage Δ
#unittests 90.00% <95.84%> (+0.83%) ⬆️
Impacted Files Coverage Δ
pulse2percept/implants/tests/test_argus.py 100.00% <ø> (ø)
pulse2percept/viz/__init__.py 100.00% <ø> (ø)
pulse2percept/implants/electrodes.py 90.65% <85.36%> (+2.81%) ⬆️
pulse2percept/implants/prima.py 94.49% <93.33%> (+33.38%) ⬆️
pulse2percept/implants/base.py 97.97% <93.93%> (-2.03%) ⬇️
pulse2percept/__init__.py 100.00% <100.00%> (ø)
pulse2percept/implants/__init__.py 100.00% <100.00%> (ø)
pulse2percept/implants/bva.py 91.17% <100.00%> (+4.33%) ⬆️
pulse2percept/implants/electrode_arrays.py 95.97% <100.00%> (+0.93%) ⬆️
pulse2percept/implants/tests/test_base.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ee3104...9232a1b. Read the comment docs.

@mbeyeler mbeyeler changed the title [ENH] Add PRIMA75, PRIMA55, PRIMA40 [ENH] [REF] Refactor implants, add PRIMA prototypes May 28, 2020
@mbeyeler mbeyeler marked this pull request as ready for review May 28, 2020 20:12
@mbeyeler mbeyeler changed the title [ENH] [REF] Refactor implants, add PRIMA prototypes [ENH] Add PRIMA prototypes May 28, 2020
@mbeyeler mbeyeler mentioned this pull request May 28, 2020
2 tasks
@mbeyeler mbeyeler merged commit 9b5b250 into pulse2percept:master May 29, 2020
@mbeyeler mbeyeler deleted the more-prima branch May 29, 2020 22:31
@mbeyeler mbeyeler added this to the v0.7 milestone Aug 19, 2020
@mbeyeler mbeyeler mentioned this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants