Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ElectrodeGrid naming convention #192

Merged
merged 3 commits into from
May 28, 2020

Conversation

mbeyeler
Copy link
Member

Fixes ElectrodeGrid naming convention when there are more than 26 alphabetic rows/columns (issue #189): new ordering is A-Z, then AA-AZ, then BA-BZ, etc.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #192 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   88.96%   88.97%           
=======================================
  Files          65       65           
  Lines        5294     5295    +1     
=======================================
+ Hits         4710     4711    +1     
  Misses        584      584           
Flag Coverage Δ
#unittests 88.97% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
pulse2percept/implants/alpha.py 92.98% <ø> (ø)
pulse2percept/implants/argus.py 93.54% <ø> (ø)
pulse2percept/implants/base.py 95.33% <100.00%> (+0.07%) ⬆️
pulse2percept/implants/tests/test_alpha.py 100.00% <100.00%> (ø)
pulse2percept/implants/tests/test_base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070848e...18cdde6. Read the comment docs.

@mbeyeler
Copy link
Member Author

I see, wheels are failing because https://status.quay.io/ is down

@mbeyeler mbeyeler merged commit 6999fc9 into pulse2percept:master May 28, 2020
@mbeyeler mbeyeler deleted the fix-grid-names branch May 28, 2020 18:20
@mbeyeler mbeyeler added this to the v0.7 milestone Aug 19, 2020
@mbeyeler mbeyeler linked an issue Aug 22, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Special characters in ElectrodeGrid names
2 participants