Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LangServe examples need to be updated #1587

Closed
scottslowe opened this issue Feb 12, 2024 · 1 comment
Closed

LangServe examples need to be updated #1587

scottslowe opened this issue Feb 12, 2024 · 1 comment
Assignees
@dirien
Labels
area/examples emergent An issue that was added to the current milestone after planning impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone
0.100

Comments

@scottslowe
Copy link
Contributor

The OpenAI LangChain libraries have changed locations and the examples need to be updated appropriately. AFAICT, the following changes need to be made:

  • Line 3 of app/server.py needs to be changed to from langchain_openai import ChatOpenAI
  • The [tool.poetry.dependencies] section of pyproject.toml needs to have langchain-openai = "^0.0.5" added
  • The poetry.lock file needs to be updated with poetry lock (else container builds will fail)

These changes need to be applied to all language variations of the the AWS LangServe examples.
@scottslowe scottslowe added kind/bug Some behavior is incorrect or out of spec area/examples size/S Estimated effort to complete (1-2 days). emergent An issue that was added to the current milestone after planning impact/regression Something that used to work, but is now broken labels Feb 12, 2024
@scottslowe scottslowe added this to the 0.100 milestone Feb 12, 2024
@lukehoban lukehoban added the p1 A bug severe enough to be the next item assigned to an engineer label Feb 13, 2024
@dirien dirien mentioned this issue Feb 13, 2024
Merged
@dirien dirien closed this as completed Feb 14, 2024
@pulumi-bot pulumi-bot reopened this Feb 14, 2024
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@dirien dirien added the resolution/fixed This issue was fixed label Feb 15, 2024
@dirien dirien closed this as completed Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirien dirien

Labels
area/examples emergent An issue that was added to the current milestone after planning impact/regression Something that used to work, but is now broken kind/bug Some behavior is incorrect or out of spec p1 A bug severe enough to be the next item assigned to an engineer resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
0.100
Development

No branches or pull requests
4 participants
@lukehoban @scottslowe @pulumi-bot @dirien