Add an example for using Pulumi with AWS Organizations #1330
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
aws-ts-organizations/README.md
Outdated
| ## Deploying and running the program | ||
|
|
||
| Note that unlike other resources that can be created/destroyed easily, | ||
| this app creates an AWS account. Read the blog post about [organizing AWS accounts with Pulumi](https://www.pulumi.com/blog/organizing-aws-accounts-with-pulumi) to learn more. |
There was a problem hiding this comment.
This is a tentative link assuming that the blog post slug doesn't change during its review process.
There was a problem hiding this comment.
Thanks! Almost there I think. We should add some clarifying prose to the README that explains what the hard requirements are to deploy this successfully, and it looks like we may need to add some code or instructions as well to be able to destroy this cleanly -- specifically the orgUnit resource. (Indeed, I am somewhat stuck here myself, as I'm not sure what "child resources" still exist -- any tips would be appreciated!)
| @@ -0,0 +1,40 @@ | |||
| # AWS Organizations | |||
| [](https://app.pulumi.com/new?template=https://github.com/pulumi/examples/blob/master/aws-ts-organizations/README.md) | |||
There was a problem hiding this comment.
Would you be up for adding a brief description of what this example does?
There was a problem hiding this comment.
@praneetloke Checking in on this one. A couple of lines would be enough I think -- just something that makes it clear to viewers what the example does. You can link to the blog post as well (I often do this).
There was a problem hiding this comment.
Ah yes. Thank you for the reminder on this one. I will add a brief intro.
There was a problem hiding this comment.
Awesome, thanks. We'll merge this as soon as that's done and then publish your post on Monday!
There was a problem hiding this comment.
@cnunciato I've just now added an intro. Can you please check the latest commit to see the changes I've made? Please do feel free to make suggestions for it.
|
@cnunciato thanks for executing this program in your personal account. I, too, did that with my account. You caught some things I enabled in my account prior to running this app. I totally missed specifying those as prerequisites. Here's what I have enabled in my root/management account:
As for being unable to delete the org unit, I suspect it might have something to do with the account being closed and that it takes 90 days before it is actually gone. Admittedly, I actually did not attempt to delete mine because I still left them up and did not encounter the issue you did. I am glad you did, though (and thank you so much for doing that!) To your earlier point, I should note this in the README. Here's a screenshot straight from their docs about closing member accounts in an organization:
|
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-example-tests |
|
Please view the results of the PR Build Here |
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-example-tests |
|
Please view the results of the PR Build Here |
|
|
||
| Note that unlike other resources that can be created/destroyed easily, | ||
| this app creates an AWS account and closed accounts are in a suspended state | ||
| for 90 days. That means, you won't be able to delete the organizational until until |
There was a problem hiding this comment.
| for 90 days. That means, you won't be able to delete the organizational until until | |
| for 90 days. That means, you won't be able to delete the organizational until |
There was a problem hiding this comment.
Thanks @praneetloke! I think all we need now is a little intro in the README that explains what the example does, and then we'll be there.
|
PR is now waiting for a maintainer to run the acceptance tests. |
pulumi-staging
bot
had a problem deploying
to
pulumi/aws-ts-s3-folder/dev
Hello, I am working on a blog post that goes along with this example. I will open a PR for the blog post shortly and update this PR description.
In terms of merge order, this should be merged first before the blog post can be merged.