Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Pulumi to GCP to OIDC Configuration Example #1513

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Create Pulumi to GCP to OIDC Configuration Example #1513

merged 6 commits into from
Oct 19, 2023

Conversation

toriancrane
Copy link
Contributor

Create Pulumi to GCP to OIDC Configuration Example

scottslowe
scottslowe suggested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments/questions, but otherwise the example functions largely as expected (I just had to fix a duplicate Workload Identity Pool name before it would work).

gcp-py-oidc-provider-pulumi-cloud/README.md Outdated Show resolved Hide resolved
gcp-py-oidc-provider-pulumi-cloud/README.md Outdated Show resolved Hide resolved
gcp-py-oidc-provider-pulumi-cloud/README.md Show resolved Hide resolved
@toriancrane toriancrane linked an issue Oct 18, 2023 that may be closed by this pull request
Content Enhancement - Add Pulumi-GCP OIDC Example for Pulumi ESC #1514
Closed
@toriancrane toriancrane merged commit 49a01b5 into master Oct 19, 2023
51 checks passed
@toriancrane toriancrane deleted the torian/gcp-py-oidc-provider-pulumi-cloud branch October 19, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottslowe scottslowe scottslowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content Enhancement - Add Pulumi-GCP OIDC Example for Pulumi ESC
2 participants
@toriancrane @scottslowe